Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbZAFMbd (ORCPT ); Tue, 6 Jan 2009 07:31:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751436AbZAFMbY (ORCPT ); Tue, 6 Jan 2009 07:31:24 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:39317 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbZAFMbY (ORCPT ); Tue, 6 Jan 2009 07:31:24 -0500 Date: Tue, 6 Jan 2009 13:31:06 +0100 From: Ingo Molnar To: Nick Piggin Cc: Nick Piggin , Yinghai Lu , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, Cliff Wickman , Jack Steiner , Russ Anderson Subject: Re: [patch] x86: make UV support optional Message-ID: <20090106123106.GB10319@elte.hu> References: <20090106060348.GA16738@wotan.suse.de> <20090106064433.GB16738@wotan.suse.de> <20090106090138.GD29917@elte.hu> <200901062323.44312.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901062323.44312.nickpiggin@yahoo.com.au> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: 0.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.5 required=5.9 tests=BAYES_00,FR_ALMOST_VIAG2 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 2.0 FR_ALMOST_VIAG2 RAW: Almost looks like viagra. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1705 Lines: 40 * Nick Piggin wrote: > On Tuesday 06 January 2009 20:01:38 Ingo Molnar wrote: > > > > > > --- > > > > > arch/x86/Kconfig | 7 +++++++ > > > > > arch/x86/include/asm/genapic.h | 24 ++++++++++++++++++++++++ > > > > > arch/x86/include/asm/genapic_32.h | 7 ------- > > > > > arch/x86/include/asm/genapic_64.h | 9 --------- > > > > > arch/x86/kernel/Makefile | 5 +++-- > > > > > arch/x86/kernel/entry_64.S | 2 ++ > > > > > arch/x86/kernel/genapic_64.c | 3 ++- > > > > > arch/x86/kernel/io_apic.c | 2 +- > > > > > 8 files changed, 39 insertions(+), 20 deletions(-) > > > > > > > > how about > > > > kernel/efi.c: efi.uv_systab = config_tables[i].table; > > > > ? > > > > > > Good point, I missed that. Will resend a patch with that ifdef'ed > > > tomorrow unless any serious objections are raised. > > > > Looks good to me, but please also extend the Makefile changes to > > kernel/tlb_uv.c, ./kernel/uv_sysfs.c, kernel/uv_irq.c, kernel/bios_uv.c - > > UV not just the genapic bits. Perhaps do it via gradual patches. > > Hmm, I think the Makefile changes should be there... the files you > reference AFAIKS are put under conditional compilation with my patch? ah, indeed - i was looking at the diffstat and went "where's the mm/Makefile changes" ;-) So your patch is good as-is, as long as the thing Yinghai noticed is fixed. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/