Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662AbZAFQih (ORCPT ); Tue, 6 Jan 2009 11:38:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750836AbZAFQi2 (ORCPT ); Tue, 6 Jan 2009 11:38:28 -0500 Received: from pfepa.post.tele.dk ([195.41.46.235]:34427 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbZAFQi1 (ORCPT ); Tue, 6 Jan 2009 11:38:27 -0500 Date: Tue, 6 Jan 2009 17:40:06 +0100 From: Sam Ravnborg To: Kamalesh Babulal Cc: Milton Miller , linux-ppc , Stephen Rothwell , linux-kernel Subject: Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH Message-ID: <20090106164006.GA15934@uranus.ravnborg.org> References: <5414eaef99b7392a95f6e3488b81dbf7@bga.com> <20090104182441.GA5086@linux.vnet.ibm.com> <98d6aef17cba9d835d7866745f811dc7@bga.com> <20090106072549.GA5066@linux.vnet.ibm.com> <20090106073149.GA12371@uranus.ravnborg.org> <20090106093847.GB5066@linux.vnet.ibm.com> <20090106104619.GA13789@uranus.ravnborg.org> <20090106155724.GA6747@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090106155724.GA6747@linux.vnet.ibm.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 36 On Tue, Jan 06, 2009 at 09:27:24PM +0530, Kamalesh Babulal wrote: > * Sam Ravnborg [2009-01-06 11:46:19]: > > > Hi Kamalesh > > > > Looks good, small nit below. > > > > > config VIOPATH > > > bool > > > - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH > > > - default y > > > + default n > > > > As 'n' is default anyway this line is not needed and I suggest you > > spin a final version of the patch with this removed. > > > > Sam > > Hi Sam, > > Thanks for the review comments. I am resending the patch with the changes > you have recommended. > > Impact: Fix the VIOPATH dependency in the iSeries dependent drivers. > > iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled. > Removing the dependency of VIOPATH by selecting it, when the drivers > dependent on iSeries code. > > Signed-off-by: Kamalesh Babulal Reviewed-by: Sam Ravnborg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/