Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753894AbZAFS3z (ORCPT ); Tue, 6 Jan 2009 13:29:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751573AbZAFS3o (ORCPT ); Tue, 6 Jan 2009 13:29:44 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52687 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbZAFS3m (ORCPT ); Tue, 6 Jan 2009 13:29:42 -0500 Date: Tue, 6 Jan 2009 10:28:38 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Steven Rostedt cc: Peter Zijlstra , Matthew Wilcox , Andi Kleen , Chris Mason , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel , linux-btrfs , Ingo Molnar , Thomas Gleixner , Gregory Haskins , Nick Piggin Subject: Re: [PATCH][RFC]: mutex: adaptive spin In-Reply-To: Message-ID: References: <1230722935.4680.5.camel@think.oraclecorp.com> <20081231104533.abfb1cf9.akpm@linux-foundation.org> <1230765549.7538.8.camel@think.oraclecorp.com> <87r63ljzox.fsf@basil.nowhere.org> <20090103191706.GA2002@parisc-linux.org> <1231093310.27690.5.camel@twins> <20090104184103.GE2002@parisc-linux.org> <1231242031.11687.97.camel@twins> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 22 On Tue, 6 Jan 2009, Steven Rostedt wrote: > > Caching the rq is an interesting idea. But since the rq struct is local to > sched.c, what would be a good API to do this? Just move the whole "spin_or_schedule()" into sched.c, and you're all done. Yeah, that requires having sched.c know a bit about mutex locking rules, but the data structures are already exported in , and while _normal_ code should never care or know exactly how it is used, I think the scheduler might as well. Mutexes are clearly very much a scheduling entity, so it's not too much of a break with internal knowledge. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/