Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755160AbZAFV7d (ORCPT ); Tue, 6 Jan 2009 16:59:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751094AbZAFV7Z (ORCPT ); Tue, 6 Jan 2009 16:59:25 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36769 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbZAFV7Y (ORCPT ); Tue, 6 Jan 2009 16:59:24 -0500 Date: Tue, 6 Jan 2009 13:59:17 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Harvey Harrison cc: Andrew Morton , LKML , Jesper Nilsson Subject: Re: [PATCH 03/23] cris: introduce asm/swab.h In-Reply-To: <1231277446.964.260.camel@brick> Message-ID: References: <1231277446.964.260.camel@brick> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 30 On Tue, 6 Jan 2009, Harvey Harrison wrote: > > cris holds its arch overrides in an arch/ folder, rename these > byteorder.h files to swab.h and include them from asm/swab.h > > Signed-off-by: Harvey Harrison > --- > arch/cris/include/arch-v10/arch/byteorder.h | 28 --------------------------- > arch/cris/include/arch-v10/arch/swab.h | 28 +++++++++++++++++++++++++++ > arch/cris/include/arch-v32/arch/byteorder.h | 22 --------------------- > arch/cris/include/arch-v32/arch/swab.h | 22 +++++++++++++++++++++ Since you'e a git user, and you're basically renaming files while then putting a new name in place, can you please send patches done with both the "-M" flag (rename detection) _and_ the "-B" flag (which breaks associations of files even if the name stays the same)? It's rare that this is needed, but it really helps. Now the patches look like a big delete/create event, and it's not at all obvious that the code is actually the same before and after. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/