Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756072AbZAFXNU (ORCPT ); Tue, 6 Jan 2009 18:13:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751938AbZAFXNL (ORCPT ); Tue, 6 Jan 2009 18:13:11 -0500 Received: from ns1.suse.de ([195.135.220.2]:50554 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbZAFXNK (ORCPT ); Tue, 6 Jan 2009 18:13:10 -0500 Date: Tue, 6 Jan 2009 15:11:59 -0800 From: Greg KH To: Robin Getz Cc: Mike Frysinger , viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: debugfs & vfs file permission issue? Message-ID: <20090106231158.GA1388@suse.de> References: <200901052157.07306.rgetz@blackfin.uclinux.org> <8bd0f97a0901052232l22b60386pbcd9438cc752638f@mail.gmail.com> <200901060705.33294.rgetz@blackfin.uclinux.org> <200901061012.38888.rgetz@blackfin.uclinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901061012.38888.rgetz@blackfin.uclinux.org> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 26 On Tue, Jan 06, 2009 at 10:12:38AM -0500, Robin Getz wrote: > On Tue 6 Jan 2009 07:05, Robin Getz suggested: > > > > adding a readonly, and writeonly, and ensuring that when you call > > debugfs_create_*, the mode is checked, and the "correct" fops are set > > doesn't seem like it would be a bad idea? This would enforce the > > kernel programmer's view on the world, and not allow pesky root users > > to override things.... > > > > Greg - would you take something like that? > > How about this? > > Feel free to nak it - we can do the same thing where we are calling the > debugfs_create_* functions - this just makes it cleaner in my opinion. I like it, want me to queue it up? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/