Date: Tue, 6 Jan 2009 15:21:23 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: 2.6.29 -mm merge plans
Message-Id: <20090106152123.a4bf1736.akpm@linux-foundation.org>
In-Reply-To: <20090106225744.GA10553@infradead.org>
References: <20090105004300.19ed52d1.akpm@linux-foundation.org>
	<20090106225744.GA10553@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1320
Lines: 32

(cc added)

On Tue, 6 Jan 2009 17:57:44 -0500
Christoph Hellwig <hch@infradead.org> wrote:

> On Mon, Jan 05, 2009 at 12:43:00AM -0800, Andrew Morton wrote:
> > generic-swap-sparc-rename-swap-to-swap_ulong.patch
> > generic-swap-iphase-rename-swap-to-swap_byte_order.patch
> > generic-swap-lib-sortc-rename-swap-to-swap_func.patch
> > generic-swap-introduce-global-macro-swapa-b.patch
> > generic-swap-ext3-remove-local-swap-macro.patch
> > generic-swap-ext4-remove-local-swap-macro.patch
> > generic-swap-sched-remove-local-swap-macro.patch
> > generic-swap-dcache-use-swap-instead-of-private-do_switch.patch
> > 
> >   Add a kernel-wide swap() macro, use it.  Merge.
> 
> Hmm, must have missed this when it went to lkml.  Having this helper
> generic is a good idea, but swap is far too generic for something
> in kernel.h as indicated by the various renaming patches. How about
> swap_vars?
> 

I thought that swap() was a good name, actually.

Sure, it's bold.  But we only have one swap() implementation,
kernel-wide, forever, right?   So what the heck: call it swap()!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/