Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756679AbZAFX0W (ORCPT ); Tue, 6 Jan 2009 18:26:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754626AbZAFX0H (ORCPT ); Tue, 6 Jan 2009 18:26:07 -0500 Received: from rv-out-0506.google.com ([209.85.198.235]:25901 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754759AbZAFX0F (ORCPT ); Tue, 6 Jan 2009 18:26:05 -0500 Message-ID: Date: Tue, 6 Jan 2009 15:26:04 -0800 From: "Warren Turkal" To: "Christoph Hellwig" Subject: Re: 2.6.29 -mm merge plans Cc: "Andrew Morton" , linux-kernel@vger.kernel.org, "Roman Zippel" , "Diego Elio 'Flameeyes' Petten?" In-Reply-To: <20090106231958.GA30271@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090105004300.19ed52d1.akpm@linux-foundation.org> <20090106225744.GA10553@infradead.org> <20090106151747.c640dfd4.akpm@linux-foundation.org> <20090106231958.GA30271@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1754 Lines: 43 I have a drive at home with the condition. So empirically, it can happen. I would also argue that having a journal bit set and then saying that the journal info block is at 0 makes no sense anyhow since the first 1024 bytes of the volume must be empty on HFS+. And, I found the previous code from Apple saying that a 0 in the journal_info_block field indicated that there was no journal. Is there anything else I should be doing? wt On Tue, Jan 6, 2009 at 3:19 PM, Christoph Hellwig wrote: > On Tue, Jan 06, 2009 at 03:17:47PM -0800, Andrew Morton wrote: >> > I'm pretty sure we already had a version better than that in your >> > tree on the list. But I've lost track and we should just restart >> > the review cycle on -fsdevel. >> >> Yeah, I have the three hfs patches: >> >> hfsplus-identify-journal-info-block-in-volume-header.patch >> hfsplus-fix-journal-detection.patch >> hfs-add-basic-export-support.patch >> >> in a holding pattern awaiting a second round, due to laggy, incomplete >> and confusing noises from various people. It all needs a revisit. > > The first two are not for me to decide. They look fine code-wise, > but IIRC Roman had some issues with wether the condition should be > possible at all. > > The third one is where I requested a respin, and I'm pretty sure I've > seen a version with some improvement over the one in your tree. Let's > get the latests version back on -fsdevel and review it again. > > The one in your tree certainly is not ready. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/