Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755753AbZAFXtT (ORCPT ); Tue, 6 Jan 2009 18:49:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751993AbZAFXtC (ORCPT ); Tue, 6 Jan 2009 18:49:02 -0500 Received: from e3.ny.us.ibm.com ([32.97.182.143]:44708 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbZAFXtA (ORCPT ); Tue, 6 Jan 2009 18:49:00 -0500 Subject: Re: [RFC][PATCH 2/4] sunrpc: Use utsnamespaces From: Matt Helsley To: Trond Myklebust Cc: "J. Bruce Fields" , "Eric W. Biederman" , "Serge E. Hallyn" , Linux Containers , linux-nfs@vger.kernel.org, Linux Kernel Mailing List , Chuck Lever , Linux Containers , Cedric Le Goater In-Reply-To: <1231284943.8041.8.camel@heimdal.trondhjem.org> References: <20090106011314.534653345@us.ibm.com> <20090106011314.961946803@us.ibm.com> <20090106200229.GA17031@us.ibm.com> <1231274682.20316.65.camel@heimdal.trondhjem.org> <20090106215831.GE18147@us.ibm.com> <1231283734.8041.6.camel@heimdal.trondhjem.org> <20090106233238.GD13785@fieldses.org> <1231284943.8041.8.camel@heimdal.trondhjem.org> Content-Type: text/plain Date: Tue, 06 Jan 2009 15:48:57 -0800 Message-Id: <1231285737.14345.173.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1616 Lines: 35 On Tue, 2009-01-06 at 18:35 -0500, Trond Myklebust wrote: > On Tue, 2009-01-06 at 18:32 -0500, J. Bruce Fields wrote: > > On Tue, Jan 06, 2009 at 06:15:34PM -0500, Trond Myklebust wrote: > > > On Tue, 2009-01-06 at 15:04 -0800, Eric W. Biederman wrote: > > > > That implies to me you want to capture the value at mount time, and to > > > > pass it in to the rpc_call creation, and only at very specific well > > > > defined points where we interact with user space should we examine > > > > current->utsname(). At which point there should be no question > > > > of current->utsname() is valid as the user space process is alive. > > > > > > Why pretend that the filesystem is owned by a particular namespace? It > > > can, and will be shared among many containers... > > > > If the only purpose of this is to fill in the auth_unix cred then > > shouldn't it be part of whatever cred structures are passed around? > > So how does tracking it in a shared structure like the rpc_client help? > If you consider it to be part of the cred, then it needs to be tracked > in the cred... > > Trond I originally discarded the idea of relating it to the credentials because it looked like the credential cache could be flushed at any time (according to the small portion of the RFC I read) so I was worried we'd have even worse lifetime issues to deal with. Cheers, -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/