Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757557AbZAGAU5 (ORCPT ); Tue, 6 Jan 2009 19:20:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754001AbZAGAUb (ORCPT ); Tue, 6 Jan 2009 19:20:31 -0500 Received: from mx2.netapp.com ([216.240.18.37]:50162 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbZAGAU2 (ORCPT ); Tue, 6 Jan 2009 19:20:28 -0500 X-IronPort-AV: E=Sophos;i="4.37,222,1231142400"; d="scan'208";a="108976943" Subject: Re: [RFC][PATCH 2/4] sunrpc: Use utsnamespaces From: Trond Myklebust To: "J. Bruce Fields" Cc: "Eric W. Biederman" , "Serge E. Hallyn" , Matt Helsley , Linux Containers , linux-nfs@vger.kernel.org, Linux Kernel Mailing List , Chuck Lever , Linux Containers , Cedric Le Goater In-Reply-To: <1231284943.8041.8.camel@heimdal.trondhjem.org> References: <20090106011314.534653345@us.ibm.com> <20090106011314.961946803@us.ibm.com> <20090106200229.GA17031@us.ibm.com> <1231274682.20316.65.camel@heimdal.trondhjem.org> <20090106215831.GE18147@us.ibm.com> <1231283734.8041.6.camel@heimdal.trondhjem.org> <20090106233238.GD13785@fieldses.org> <1231284943.8041.8.camel@heimdal.trondhjem.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: NetApp Date: Tue, 06 Jan 2009 19:20:07 -0500 Message-Id: <1231287607.11487.0.camel@heimdal.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 X-OriginalArrivalTime: 07 Jan 2009 00:20:26.0868 (UTC) FILETIME=[BD66F340:01C9705D] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 32 On Tue, 2009-01-06 at 18:35 -0500, Trond Myklebust wrote: > So how does tracking it in a shared structure like the rpc_client help? > If you consider it to be part of the cred, then it needs to be tracked > in the cred... OK. If people really want to track this, then you could add a reference to the current->nsproxy to the struct rpc_cred and struct auth_cred, and ensure that the unx_marshal and unx_match routines do the right thing w.r.t. that reference (if it exists). However such a patch had better be accompanied with a _really_ convincing argument for why containers need this... As for the NFSv4 clientid, I can't see how you would ever want to use anything other than the init->utsname(), since the requirement is only that the clientid string be unique and preserved across reboots. The server isn't allowed to interpret the contents of the clientid string. Ditto for the RPCSEC_GSS machine creds that are used to establish the clientid. Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/