Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755987AbZAGF1K (ORCPT ); Wed, 7 Jan 2009 00:27:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751123AbZAGF04 (ORCPT ); Wed, 7 Jan 2009 00:26:56 -0500 Received: from relais.videotron.ca ([24.201.245.36]:49641 "EHLO relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbZAGF04 (ORCPT ); Wed, 7 Jan 2009 00:26:56 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: TEXT/PLAIN; charset=US-ASCII Date: Wed, 07 Jan 2009 00:26:50 -0500 (EST) From: Nicolas Pitre X-X-Sender: nico@xanadu.home To: Linus Torvalds Cc: Benjamin Herrenschmidt , Linux Kernel Mailing List , Harvey Harrison Subject: Re: powerpc: introduce asm/swab.h In-reply-to: Message-id: References: <200901070400.n0740Ore002063@hera.kernel.org> <1231303340.14860.61.camel@pasglop> <1231304552.14860.72.camel@pasglop> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 34 On Wed, 7 Jan 2009, Nicolas Pitre wrote: > On Tue, 6 Jan 2009, Linus Torvalds wrote: > > > > > > > On Wed, 7 Jan 2009, Benjamin Herrenschmidt wrote: > > > > > > Even if fixing that to use __swab32() instead, then it fails because > > > this is defined after it's used. I worked around it using fswab in > > > there instead. > > > > That's the same patch I just sent out (but you changed comments too), so I > > obviously agree. > > > > x86 didn't see this (even in 32-bit mode) because it doesn't use that odd > > __SWAB_64_THRU_32__ case, but does the 64-bit swab with native code. > > > > Can you also verify that it works for you (not just compiles), just so > > that I can commit it? > > Tested OK on ARM (using LE mode with networking, etc.) Well, given that I have no way to test any code path including be64_to_cpu() and its opposite, my testing is only valid for compilation issues. Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/