Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753431AbZAGLu7 (ORCPT ); Wed, 7 Jan 2009 06:50:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751631AbZAGLur (ORCPT ); Wed, 7 Jan 2009 06:50:47 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:45248 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751073AbZAGLur (ORCPT ); Wed, 7 Jan 2009 06:50:47 -0500 Date: Wed, 7 Jan 2009 22:50:32 +1100 From: Herbert Xu To: Evgeniy Polyakov Cc: Jens Axboe , Willy Tarreau , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Data corruption issue with splice() on 2.6.27.10 Message-ID: <20090107115032.GA25198@gondor.apana.org.au> References: <20081224152841.GB13113@1wt.eu> <20090106183223.GA11964@ioremap.net> <20090106183704.GC32491@kernel.dk> <20090107044232.GA22218@gondor.apana.org.au> <20090107112906.GA28161@ioremap.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090107112906.GA28161@ioremap.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 22 On Wed, Jan 07, 2009 at 02:29:06PM +0300, Evgeniy Polyakov wrote: > > That would not happen without scatter-gather support on the interface, > date would be plain copied, and after Jarek's requst Willy confirmed > that corruption happens with all acceleration being turned off. It will happen without scatter-gather support. The problem is with skb->head, which is always there. In any case, SG can't make any difference because the skb is an inbound one and most drivers only produce linear packets. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/