Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754006AbZAGL4V (ORCPT ); Wed, 7 Jan 2009 06:56:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751893AbZAGL4J (ORCPT ); Wed, 7 Jan 2009 06:56:09 -0500 Received: from broadrack.ru ([195.178.208.66]:33497 "EHLO tservice.net.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbZAGL4I (ORCPT ); Wed, 7 Jan 2009 06:56:08 -0500 Date: Wed, 7 Jan 2009 14:56:05 +0300 From: Evgeniy Polyakov To: Herbert Xu Cc: Jens Axboe , Willy Tarreau , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Data corruption issue with splice() on 2.6.27.10 Message-ID: <20090107115605.GA29250@ioremap.net> References: <20081224152841.GB13113@1wt.eu> <20090106183223.GA11964@ioremap.net> <20090106183704.GC32491@kernel.dk> <20090107044232.GA22218@gondor.apana.org.au> <20090107112906.GA28161@ioremap.net> <20090107115032.GA25198@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090107115032.GA25198@gondor.apana.org.au> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 20 On Wed, Jan 07, 2009 at 10:50:32PM +1100, Herbert Xu (herbert@gondor.apana.org.au) wrote: > > That would not happen without scatter-gather support on the interface, > > date would be plain copied, and after Jarek's requst Willy confirmed > > that corruption happens with all acceleration being turned off. > > It will happen without scatter-gather support. The problem > is with skb->head, which is always there. In any case, SG can't > make any difference because the skb is an inbound one and most > drivers only produce linear packets. But it will not push pages into the stack, but copy them including copy of the submitted head? -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/