Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757593AbZAGNXY (ORCPT ); Wed, 7 Jan 2009 08:23:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751901AbZAGNXL (ORCPT ); Wed, 7 Jan 2009 08:23:11 -0500 Received: from ug-out-1314.google.com ([66.249.92.172]:5868 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbZAGNXJ (ORCPT ); Wed, 7 Jan 2009 08:23:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=GJCNoDHFkxxhk/MPq76w8l91S1HsMR3m/JlJeyNreTmLeghlmZdCrInMBIhxw7MdnD i9o0SrKJomQAromobm0nu1Ta0FOoqbVQx6esJoV0RDhov5BJIwIlRBSpyyorTc5aaNWK X2RiDTPhdjD/FrdRM6Sin85xj1IP35WjWfXIk= Date: Wed, 7 Jan 2009 13:22:58 +0000 From: Jarek Poplawski To: Willy Tarreau Cc: Evgeniy Polyakov , Herbert Xu , Jens Axboe , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Data corruption issue with splice() on 2.6.27.10 Message-ID: <20090107132258.GE9677@ff.dom.local> References: <20090107121530.GA30164@ioremap.net> <20090107122238.GB25673@gondor.apana.org.au> <20090107123741.GA31255@ioremap.net> <20090107124246.GA26034@gondor.apana.org.au> <20090107124629.GA31732@ioremap.net> <20090107125535.GC6307@1wt.eu> <20090107125734.GA26331@gondor.apana.org.au> <20090107130259.GB32336@ioremap.net> <20090107131057.GD9677@ff.dom.local> <20090107131539.GF6307@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090107131539.GF6307@1wt.eu> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 27 On Wed, Jan 07, 2009 at 02:15:39PM +0100, Willy Tarreau wrote: > On Wed, Jan 07, 2009 at 01:10:57PM +0000, Jarek Poplawski wrote: > > On Wed, Jan 07, 2009 at 04:02:59PM +0300, Evgeniy Polyakov wrote: > > ... > > > If I understood correctly Jarek's patch, he wants to allocate a page and > > > copy linear content of the skb there, so this will end up being the same > > > case as with splicing from the file. And while generally this may be a > > > good idea, but with usual 1.5k mtu this will copy every skb, which is > > > rather bad idea. Will have to think :) > > > > > > > As I mentioned earlier, I (poorly) tried to realize Changli's idea > > only, and it's more to verify the reason still (after it failed with > > SG method...). > > Jarek, since it now works when disabling both SG and GSO, we know that the > bug is triggered when passing through do_tcp_sendpage(). Thus, I will not > try your patch #3 yet, but rather wait for fix candidates to try. Sure! Congratulations for debugging to you and Evgeniy! Jarek P. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/