Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756809AbZAGOXi (ORCPT ); Wed, 7 Jan 2009 09:23:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753827AbZAGOX1 (ORCPT ); Wed, 7 Jan 2009 09:23:27 -0500 Received: from smtp4-ft1.vinci-energies.com ([81.252.86.87]:59249 "EHLO vinci-energies.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754118AbZAGOX1 (ORCPT ); Wed, 7 Jan 2009 09:23:27 -0500 From: BARRE Sebastien To: Ed Swierk CC: "linux-i2c@vger.kernel.org" , David Brownell , Alessandro Zummo , "linux-kernel@vger.kernel.org" , Andrew Morton , Jean Delvare Date: Wed, 7 Jan 2009 15:22:19 +0100 Subject: RE: [PATCH] rtc-ds1307: True SMBus compatibility Thread-Topic: [PATCH] rtc-ds1307: True SMBus compatibility Thread-Index: AclwTBDPwykVJJUtQlu8gw5EwdNp2gAhLL0w Message-ID: References: <1231176979.13443.19.camel@localhost.localdomain> <1231280024.12030.2.camel@localhost.localdomain> In-Reply-To: <1231280024.12030.2.camel@localhost.localdomain> Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: fr-FR, en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha id n07ENgwM007825 Content-Length: 1482 Lines: 47 > -----Original Message----- > From: Ed Swierk [mailto:eswierk@aristanetworks.com] > Sent: Tuesday, January 06, 2009 11:14 PM > To: BARRE Sebastien > Cc: linux-i2c@vger.kernel.org; David Brownell; Alessandro Zummo; linux- > kernel@vger.kernel.org; Andrew Morton > Subject: Re: [PATCH] rtc-ds1307: True SMBus compatibility > > On Tue, Jan 6, 2009 at 5:35 AM, BARRE Sebastien wrote: > > I've read your patch quicly, I will test it on my board as soon as > possible. > > Thanks. > > > You can delete the next 3 lines, they are not useful: > > > >> + ret = ds1307_read_block_data_once(client, command, length, > currvalues); > >> + if (ret < 0) > >> + return ret; > > Oops! Here is an updated patch with these lines removed, and a minor > formatting fix. > > Signed-off-by: Ed Swierk > > --Ed I've tested the patch on my geode LX board with a DS1307 device. It works well for me. However I think writing the clock one byte at a time could cause strange behavior when using alarms on device like ds1337. Tested-by: Sébastien Barré -- Sébastien Barré Bureau d'étude - Développement SDEL Contrôle Commande D2A - Rue Nungesser et Coli 44860 Saint Aignan de Grand Lieu FRANCE Tél : +33(0)2 40 84 50 88 Fax : +33(0)2 40 84 51 10 ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?