Date: Wed, 7 Jan 2009 13:35:35 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: torvalds@linux-foundation.org, peterz@infradead.org,
       paulmck@linux.vnet.ibm.com, ghaskins@novell.com, mingo@elte.hu,
       matthew@wil.cx, andi@firstfloor.org, chris.mason@oracle.com,
       linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       linux-btrfs@vger.kernel.org, tglx@linutronix.de, rostedt@goodmis.org,
       npiggin@suse.de, pmorreale@novell.com, SDietrich@novell.com
Subject: Re: [PATCH -v5][RFC]: mutex: implement adaptive spinning
Message-Id: <20090107133535.858ce125.akpm@linux-foundation.org>
In-Reply-To: <20090107213740.GO496@one.firstfloor.org>
References: <1231278275.11687.111.camel@twins>
	<alpine.LFD.2.00.0901061349520.3057@localhost.localdomain>
	<1231279660.11687.121.camel@twins>
	<alpine.LFD.2.00.0901061413310.3057@localhost.localdomain>
	<1231281801.11687.125.camel@twins>
	<1231283778.11687.136.camel@twins>
	<1231329783.11687.287.camel@twins>
	<alpine.LFD.2.00.0901070816450.3057@localhost.localdomain>
	<1231347442.11687.344.camel@twins>
	<alpine.LFD.2.00.0901071016340.3057@localhost.localdomain>
	<20090107213740.GO496@one.firstfloor.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1485
Lines: 28

On Wed, 7 Jan 2009 22:37:40 +0100
Andi Kleen <andi@firstfloor.org> wrote:

> > But we can do that with __get_user(thread_info->cpu) (very unlikely page 
> > fault protection due to the possibility of CONFIG_DEBUG_PAGEALLOC) and 
> > then validating the cpu. It it's in range, we can use it and verify 
> > whether cpu_rq(cpu)->curr has that thread_info.
> > 
> > So we can do all that locklessly and optimistically, just going back and 
> > verifying the results later. This is why "thread_info" is actually a 
> > better thing to use than "task_struct" - we can look up the cpu in it with 
> > a simple dereference. We knew the pointer _used_ to be valid, so in any 
> > normal situation, it will never page fault (and if you have 
> > CONFIG_DEBUG_PAGEALLOC and hit a very unlucky race, then performance isn't 
> > your concern anyway: we just need to make the page fault be non-lethal ;)
> 
> The problem with probe_kernel_address() is that it does lots of
> operations around the access in the hot path (set_fs, pagefault_disable etc.), 
> so i'm not sure that's a good idea. 

probe_kernel_address() isn't tooooo bad - a few reads and writes into
the task_struct and thread_struct.  And we're on the slow, contended
path here anyway..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/