Date: Wed, 7 Jan 2009 17:17:45 -0800
From: Arjan van de Ven <arjan@infradead.org>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
       akpm@linux-foundation.org
Subject: Re: [PATCH 1/7] async: Asynchronous function calls to speed up
 kernel boot
Message-ID: <20090107171745.3a825edc@infradead.org>
In-Reply-To: <20090108003141.GN23891@ghostprotocols.net>
References: <20090107151151.458333c1@infradead.org>
	<20090107151226.58264d07@infradead.org>
	<20090108003141.GN23891@ghostprotocols.net>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 757
Lines: 25

On Wed, 7 Jan 2009 22:31:41 -0200
Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Small nitpick:
> 
> - > +		return entry->cookie;
> > +	} else if (!list_empty(running)) {
> > +		entry = list_first_entry(running,
> > +			struct async_entry, list);
> - > +		return entry->cookie;
> > +	} else {
> > +		/* nothing in progress... next_cookie is
> > "infinity" */
> > +		return next_cookie;
> > +	}
> 
> + 	return entry->cookie;

no you cannot do this; entry can be freed by this time already from a
thread.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/