Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758346AbZAHKNl (ORCPT ); Thu, 8 Jan 2009 05:13:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751676AbZAHKNd (ORCPT ); Thu, 8 Jan 2009 05:13:33 -0500 Received: from wf-out-1314.google.com ([209.85.200.171]:45520 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbZAHKNc (ORCPT ); Thu, 8 Jan 2009 05:13:32 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=eSmH6utueTY5q6iMDTry+pB4y+v/wBPBM2rBdi5SqPtCDFYnAa9/4pwA9z76Yi7ANa ezB6VGXHLLKTxDPU3GA1hV+8FBtEypO77Z68YiNrr6TX3VRdjpPc/zYfeAdJjhLMy5/l /4epk1JGQ2NCLpqqS/kBwNbv6qWlB0T4Z8I6k= Subject: Re: [PATCH 1/3] w35und: Move ETH_LENGTH_OF_ADDRESS to wbhal_s.h From: Harvey Harrison To: Pekka Enberg Cc: Greg Kroah-Hartman , Pavel Machek , linux-kernel@vger.kernel.org In-Reply-To: <1231408613.9373.5.camel@penberg-laptop> References: <1231408018.5539.6.camel@brick> <1231408613.9373.5.camel@penberg-laptop> Content-Type: text/plain Date: Thu, 08 Jan 2009 02:13:30 -0800 Message-Id: <1231409610.5539.7.camel@brick> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 29 On Thu, 2009-01-08 at 11:56 +0200, Pekka Enberg wrote: > On Thu, 2009-01-08 at 01:46 -0800, Harvey Harrison wrote: > > On Thu, 2009-01-08 at 11:30 +0200, Pekka J Enberg wrote: > > > From: Pekka Enberg > > > > > > +#define ETH_LENGTH_OF_ADDRESS 6 > > > > Or just use ETH_ALEN like the rest of the kernel and drop this guy. > > Even better, thanks Harvey! Greg, please use this one instead. The rest > of the series is unaffected by the changes in this patch. > > >From c849ed5b5e68953a72f8dc43066513f118822f94 Mon Sep 17 00:00:00 2001 > From: Pekka Enberg > Date: Thu, 8 Jan 2009 11:10:06 +0200 > Subject: [PATCH] w35und: convert code to use ETH_ALEN > > As suggested by Harvey Harrison, convert driver to use ETH_ALEN and kill a > private macro from common.h that is used for the same thing. Untested, but obviously ACK the approach :-) Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/