Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759928AbZAHOYW (ORCPT ); Thu, 8 Jan 2009 09:24:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756597AbZAHOYH (ORCPT ); Thu, 8 Jan 2009 09:24:07 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:45046 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755737AbZAHOYG (ORCPT ); Thu, 8 Jan 2009 09:24:06 -0500 Date: Thu, 8 Jan 2009 09:24:03 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Andi Kleen cc: Linus Torvalds , Dave Kleikamp , Peter Zijlstra , paulmck@linux.vnet.ibm.com, Gregory Haskins , Ingo Molnar , Matthew Wilcox , Chris Mason , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich Subject: Re: [PATCH -v5][RFC]: mutex: implement adaptive spinning In-Reply-To: <20090108065235.GX496@one.firstfloor.org> Message-ID: References: <1231347442.11687.344.camel@twins> <1231365115.11687.361.camel@twins> <1231368870.6686.16.camel@norville.austin.ibm.com> <20090108065235.GX496@one.firstfloor.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 33 On Thu, 8 Jan 2009, Andi Kleen wrote: > > What about memory hotplug as Ingo mentioned? > > > > Should that be: > > > > #if defined(CONFIG_DEBUG_PAGEALLOC) || defined(CONFIG_MEMORY_HOTPLUG) > > We expect memory hotunplug to only really work in movable zones > (all others should at least have one kernel object somewhere that prevents > unplug) and you can't have task structs in movable zones obviously > > So it's probably a non issue in practice. Sure, it probably is a non issue, but I'm afraid that non issues of today might become issues of tomorrow. Where does it say that we can never put a task struct in a movable zone. Perhaps, we could someday have a CPU with memory local to it, and pinned tasks to that CPU in that memory. Then there can be cases where we remove the CPU and memory together. Because of preemption in the mutex spin part, there's no guarantee that a the task in that removed memory will not be referenced again. Of course this thought is purely theoretical, but I like to solve bugs that might might happen tomorrow too. ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/