Return-Path: <linux-kernel-owner+w=401wt.eu-S1760418AbZAHPTZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760418AbZAHPTZ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 8 Jan 2009 10:19:25 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754342AbZAHPTO
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 8 Jan 2009 10:19:14 -0500
Received: from casper.infradead.org ([85.118.1.10]:60316 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754036AbZAHPTN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 8 Jan 2009 10:19:13 -0500
Date: Thu, 8 Jan 2009 07:21:11 -0800
From: Arjan van de Ven <arjan@infradead.org>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Grissiom <chaos.proton@gmail.com>, linux-kernel@vger.kernel.org,
       linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest
 git
Message-ID: <20090108072111.1ebadebd@infradead.org>
In-Reply-To: <1231425472.21528.13.camel@norville.austin.ibm.com>
References: <a0adeea50901080007q5a3ed5c8y5a744ce37e677325@mail.gmail.com>
	<1231425472.21528.13.camel@norville.austin.ibm.com>
Organization: Intel
X-Mailer: Claws Mail 3.6.1 (GTK+ 2.14.5; i386-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <arjan@infradead.org> by casper.infradead.org
	See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2322
Lines: 54

On Thu, 08 Jan 2009 08:37:52 -0600
Dave Kleikamp <shaggy@linux.vnet.ibm.com> wrote:

> Adding cc:lix-fsdevel
> 
> On Thu, 2009-01-08 at 16:07 +0800, Grissiom wrote:
> > When I using the latest git version, I occasionally got this in
> > dmesg:
> > 
> > [ 2008.237234] BUG: scheduling while atomic: pdflush/30/0x00000002
> > [ 2008.237240] 2 locks held by pdflush/30:
> > [ 2008.237244]  #0:  (mutex){--..}, at: [<c01a57a1>]
> > sync_filesystems+0x11/0x120 [ 2008.237258]  #1:  (sb_lock){--..},
> > at: [<c01a57ab>] sync_filesystems+0x1b/0x120
> > [ 2008.237277] Modules linked in: fuse ricoh_mmc b43
> > [ 2008.237288] Pid: 30, comm: pdflush Not tainted
> > 2.6.28-g14-rfkill-nophy-ledon-07485-g9e42d0c #62
> > [ 2008.237294] Call Trace:
> > [ 2008.237303]  [<c04d7576>] schedule+0x326/0x8e0
> > [ 2008.237311]  [<c01500d3>] __lock_acquire+0x293/0xa20
> > [ 2008.237321]  [<c014e307>] mark_held_locks+0x67/0x80
> > [ 2008.237330]  [<c04da58c>] _spin_unlock_irqrestore+0x4c/0x60
> > [ 2008.237339]  [<c014e519>] trace_hardirqs_on_caller+0x149/0x1a0
> > [ 2008.237351]  [<c0143d55>]
> > async_synchronize_cookie_special+0xb5/0x140 [ 2008.237362]
> > [<c013e1a0>] autoremove_wake_function+0x0/0x40 [ 2008.237372]
> > [<c01a57fc>] sync_filesystems+0x6c/0x120 [ 2008.237381]
> > [<c017ee90>] pdflush+0x0/0x1e0 [ 2008.237392]  [<c01c0b90>]
> > do_sync+0x20/0x60 [ 2008.237402]  [<c01c0bda>] sys_sync+0xa/0x10
> > [ 2008.237412]  [<c017ef9e>] pdflush+0x10e/0x1e0
> > [ 2008.237420]  [<c014e519>] trace_hardirqs_on_caller+0x149/0x1a0
> > [ 2008.237429]  [<c017de80>] laptop_flush+0x0/0x10
> > [ 2008.237437]  [<c013dea2>] kthread+0x42/0x70
> > [ 2008.237444]  [<c013de60>] kthread+0x0/0x70
> > [ 2008.237452]  [<c0103c03>] kernel_thread_helper+0x7/0x14
> > (repeat some times)
> > 
> 
> The offender is
> http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=efaee192
> 
> async_synchronize_full_special() shouldn't be called while holding a
> spinlock, sb_lock.
> 
> I think this patch should fix it.  Arjan, would this work?

yeah it will

woops/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/