From: Frans Pop <elendil@planet.nl>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [Regression] USB wakeup problem on Toshiba Portege R500
Date: Thu, 8 Jan 2009 19:55:09 +0100
User-Agent: KMail/1.9.9
Cc: oliver@neukum.org, stern@rowland.harvard.edu, gregkh@suse.de,
       akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       linux-pm@lists.linux-foundation.org, pavel@suse.cz,
       torvalds@linux-foundation.org
References: <200901080835.39639.rjw@sisk.pl> <200901081736.12926.rjw@sisk.pl> <200901081748.58962.oliver@neukum.org> <200901081748.58962.oliver@neukum.org> <200901081803.49632.rjw@sisk.pl>
In-reply-To: <200901081803.49632.rjw@sisk.pl>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901081955.12021.elendil@planet.nl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1776
Lines: 42

Rafael J. Wysocki wrote:
> On Thursday 08 January 2009, Oliver Neukum wrote:
>> Am Thursday 08 January 2009 17:36:12 schrieb Rafael J. Wysocki:
>> You are making a very persuasive argument for reverting it.
>> But what about laptops that only have a USB keyboard?
> 
> Well, up to and including 2.6.28 they needed to echo 'enable' to the USB
> controllers' /sys/devices/.../power/wakeup files, so if the patch is
> reverted, they won't be worse off than they were day before
> yesterday. :-) 
> 
> Perhaps we can choose the default depending on whether or not any HID
> devices are attached to given controller?

Is "resume on keyboard activity" really all that needed? Both my laptops 
and my desktop resume fine after pressing the power button.

Also consider the following cases:
- laptop has been suspended with external USB mouse connected
  - mouse is moved (accidentally or because it is in the way of a coffee
    cup)
  - mouse cable is removed before putting the laptop in a bag for
    transport
- laptop is in docking station with USB mouse/kbd connected to that
  - again, mouse gets moved for some reason
  - laptop is undocked while suspended
  - or the reverse: laptop gets docked

IMO it is not desirable that the system gets resumed as a result of any of 
those actions. I'm not complete sure that it would in all those cases, 
but have they been considered?

And in general I've always been in favor of things only happening 
automagically if I've explicitly asked for that, and not by default.

My 2 cents,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/