Date: Thu, 08 Jan 2009 10:55:31 -0800 (PST)
Message-Id: <20090108.105531.176161465.davem@davemloft.net>
To: cooloney@kernel.org
Cc: jeff@garzik.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       graf.yang@analog.com
Subject: Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin
 MAC driver
From: David Miller <davem@davemloft.net>
In-Reply-To: <1231344879-26069-3-git-send-email-cooloney@kernel.org>
References: <1231344879-26069-1-git-send-email-cooloney@kernel.org>
	<1231344879-26069-3-git-send-email-cooloney@kernel.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 980
Lines: 29

From: Bryan Wu <cooloney@kernel.org>
Date: Thu,  8 Jan 2009 00:14:39 +0800

> +#define VLAN_ETHER_TYPE 0x8100

Please use ETH_P_8021Q from linux/if_ether.h instead of inventing
your own definition.

> +	/* The legal length of the frame is increased to 1538 bytes */
> +	/*bfin_write_EMAC_VLAN2(VLAN_ETHER_TYPE);*/

Please do not add code that is just going to be commented
out and not used.

Also, I disagree with the:

+#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)

conditional.  Probably this part of the chip should be programmed
unconditionally.

We can get VLAN packets received and sent, using AF_PACKET
sockets, for example.  The chip should still respect those
even if VLAN proper is not being utilized.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/