Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759298AbZAHUul (ORCPT ); Thu, 8 Jan 2009 15:50:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752389AbZAHUuc (ORCPT ); Thu, 8 Jan 2009 15:50:32 -0500 Received: from mail3.caviumnetworks.com ([12.108.191.235]:55528 "EHLO mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269AbZAHUuc (ORCPT ); Thu, 8 Jan 2009 15:50:32 -0500 Message-ID: <496666CE.3050205@caviumnetworks.com> Date: Thu, 08 Jan 2009 12:49:18 -0800 From: David Daney User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Linus Torvalds CC: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier. References: <1231446081-8448-1-git-send-email-ddaney@caviumnetworks.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 08 Jan 2009 20:49:18.0545 (UTC) FILETIME=[9351C410:01C971D2] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 23 Linus Torvalds wrote: [...] > In fact, I think it already is a no-op in the UP case, and you can > literally just do > > static inline void __init init_irq_default_affinity(void) > { > alloc_cpumask_var(&irq_default_affinity, GFP_KERNEL); > cpumask_setall(irq_default_affinity); > } > > and be done with it. I think it should all compile away to nothing if > CONFIG_SMP isn't set. The 'inline' seems gratuitous to me. Since it is static GCC should do the Right Thing. However since you suggested it, I am testing it that way. David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/