Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761856AbZAHX30 (ORCPT ); Thu, 8 Jan 2009 18:29:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752690AbZAHX3L (ORCPT ); Thu, 8 Jan 2009 18:29:11 -0500 Received: from mx2.redhat.com ([66.187.237.31]:54496 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbZAHX3H (ORCPT ); Thu, 8 Jan 2009 18:29:07 -0500 Date: Thu, 8 Jan 2009 21:28:47 -0200 From: Arnaldo Carvalho de Melo To: Leonardo Potenza , David Miller , Gerrit Renker Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, DCCP Mailing List , Linux Networking Development Mailing List Subject: Re: [PATCH] net: fix section mismatch warnings in dccp/ccids/lib/tfrc.c Message-ID: <20090108232847.GV23891@ghostprotocols.net> Mail-Followup-To: Arnaldo Carvalho de Melo , Leonardo Potenza , David Miller , Gerrit Renker , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, DCCP Mailing List , Linux Networking Development Mailing List References: <200901081957.03413.lpotenza@inwind.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901081957.03413.lpotenza@inwind.it> X-Url: http://oops.ghostprotocols.net:81/blog User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2020 Lines: 52 Adding netdev to the CC list. Em Thu, Jan 08, 2009 at 07:57:03PM +0100, Leonardo Potenza escreveu: > From: Leonardo Potenza > > Removed the __exit annotation of tfrc_lib_exit(), in order to suppress the following section mismatch messages: > > WARNING: net/dccp/dccp.o(.text+0xd9): Section mismatch in reference from the function ccid_cleanup_builtins() to the function .exit.text:tfrc_lib_exit() > The function ccid_cleanup_builtins() references a function in an exit section. > Often the function tfrc_lib_exit() has valid usage outside the exit section > and the fix is to remove the __exit annotation of tfrc_lib_exit. > > WARNING: net/dccp/dccp.o(.init.text+0x48): Section mismatch in reference from the function ccid_initialize_builtins() to the function .exit.text:tfrc_lib_exit() > The function __init ccid_initialize_builtins() references > a function __exit tfrc_lib_exit(). > This is often seen when error handling in the init function > uses functionality in the exit path. > The fix is often to remove the __exit annotation of > tfrc_lib_exit() so it may be used outside an exit section. > > Signed-off-by: Leonardo Potenza > --- > Index: linux-2.6/net/dccp/ccids/lib/tfrc.c > =================================================================== > --- linux-2.6.orig/net/dccp/ccids/lib/tfrc.c 2009-01-08 19:19:50.000000000 +0100 > +++ linux-2.6/net/dccp/ccids/lib/tfrc.c 2009-01-08 19:20:07.000000000 +0100 > @@ -36,7 +36,7 @@ out: > return rc; > } > > -void __exit tfrc_lib_exit(void) > +void tfrc_lib_exit(void) > { > tfrc_rx_packet_history_exit(); > tfrc_tx_packet_history_exit(); Thanks Leonardo, Dave/Gerrit, Please apply. Acked-by: Arnaldo Carvalho de Melo Thanks, - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/