Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756056AbZAIEpb (ORCPT ); Thu, 8 Jan 2009 23:45:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753254AbZAIEpS (ORCPT ); Thu, 8 Jan 2009 23:45:18 -0500 Received: from mga12.intel.com ([143.182.124.36]:20872 "EHLO azsmga102.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753118AbZAIEpR (ORCPT ); Thu, 8 Jan 2009 23:45:17 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.37,237,1231142400"; d="scan'208";a="98076220" Message-ID: <4966D652.4070105@linux.intel.com> Date: Thu, 08 Jan 2009 20:45:06 -0800 From: Arjan van de Ven User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Arjan van de Ven , Dave Kleikamp , Linus Torvalds , Grissiom , linux-kernel@vger.kernel.org, linux-fsdevel Subject: Re: [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock References: <1231425472.21528.13.camel@norville.austin.ibm.com> <20090108072111.1ebadebd@infradead.org> <1231429591.27353.14.camel@norville.austin.ibm.com> <20090108225050.GL9448@disturbed> <49668388.708@linux.intel.com> <20090109014054.GN9448@disturbed> In-Reply-To: <20090109014054.GN9448@disturbed> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 25 Dave Chinner wrote: > > So, given the potential impact of this change, what testing have > you done in terms of: > > - performance impact I tested this on my machines and it gave a real performance improvement (11 to 8 seconds for a full kernel tree unlink, and cutting out latency for normal applications) > - sync() safety that was exactly the synchronization point that's discussed here. > - removing a million files and queuing all of the > deletes in the async queues.... the async code throttles at 32k outstanding. Yes 32K is arbitrary, but if you delete a million files fast, all but the first few thousand are synchronous. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/