Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbZAIFGO (ORCPT ); Fri, 9 Jan 2009 00:06:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754267AbZAIFFu (ORCPT ); Fri, 9 Jan 2009 00:05:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:57679 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754095AbZAIFFt (ORCPT ); Fri, 9 Jan 2009 00:05:49 -0500 Date: Thu, 8 Jan 2009 08:30:24 -0800 From: Greg KH To: Davide Rizzo Cc: "Hans J. Koch" , linux-kernel@vger.kernel.org, ben-linux@fluff.org Subject: Re: [PATCH 1/3] Driver for user access to internal clocks Message-ID: <20090108163024.GB26413@suse.de> References: <8447d6730901080149l4146139an9fad00fd88d72fb9@mail.gmail.com> <20090108112741.GA3053@local> <8447d6730901080806r238354c7u81071a28d8b483ff@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8447d6730901080806r238354c7u81071a28d8b483ff@mail.gmail.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 24 On Thu, Jan 08, 2009 at 05:06:58PM +0100, Davide Rizzo wrote: > > Davide, > > please don't put this in the drivers/uio/ directory. This is no UIO driver. > > > > Thanks, > > Hans > > > Ok, moved to /drivers/misc > > This driver is for user level programs to interact with system clocks. Same comments here as for your "timer.c" file: - too generic of a name - needs proper documentation - send any kernel api changes also to linux-api@vger.kernel.org thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/