Date: Fri, 09 Jan 2009 23:06:26 +0900 (JST)
Message-Id: <20090109.230626.126760668.anemo@mba.ocn.ne.jp>
To: haavard.skinnemoen@atmel.com
Cc: linux-kernel@vger.kernel.org, maciej.sosnowski@intel.com,
       dan.j.williams@intel.com
Subject: Re: dw_dmac driver questions
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <20090105.230230.132760259.anemo@mba.ocn.ne.jp>
References: <20081229.233932.25909762.anemo@mba.ocn.ne.jp>
	<20090105.230230.132760259.anemo@mba.ocn.ne.jp>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1279
Lines: 36

On Mon, 05 Jan 2009 23:02:30 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Mon, 29 Dec 2008 23:39:32 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> > Hi.  I'm writing a new DMA driver, using dw_dmac driver in kernel
> > 2.6.28 as a reference implementation.
> > 
> > I can see an outline of the dw_dmac driver and framework (well,
> > hopefully), but have some questions in details.
> 
> One more.

One more again.

5. dwc_issue_pending()

Is this needed?  The dwc_tx_submit might queue the descriptor, but it
should be issued automatically after completion of all descriptors in
active list.

It yes, it seems implementation like this would be possible:

* dwc_tx_submit() just always add the descriptor to queue list even if
  active list was empty.

* dwc_issue_pending() call dwc_dostart() and move queued descriptor(s)
  to active list, if the active list was empty.

But I'm not sure "chain as many as possible at a time" is really
better then "start engine as soon as possible".

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/