Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbZAIPzd (ORCPT ); Fri, 9 Jan 2009 10:55:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751521AbZAIPzY (ORCPT ); Fri, 9 Jan 2009 10:55:24 -0500 Received: from netrider.rowland.org ([192.131.102.5]:2030 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751045AbZAIPzX (ORCPT ); Fri, 9 Jan 2009 10:55:23 -0500 Date: Fri, 9 Jan 2009 10:55:21 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Frans Pop cc: "Rafael J. Wysocki" , , , , , , , Subject: Re: [Regression] USB wakeup problem on Toshiba Portege R500 In-Reply-To: <200901081955.12021.elendil@planet.nl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2784 Lines: 66 On Thu, 8 Jan 2009, Frans Pop wrote: > Rafael J. Wysocki wrote: > > On Thursday 08 January 2009, Oliver Neukum wrote: > >> Am Thursday 08 January 2009 17:36:12 schrieb Rafael J. Wysocki: > >> You are making a very persuasive argument for reverting it. > >> But what about laptops that only have a USB keyboard? > > > > Well, up to and including 2.6.28 they needed to echo 'enable' to the USB > > controllers' /sys/devices/.../power/wakeup files, so if the patch is > > reverted, they won't be worse off than they were day before > > yesterday. :-) > > > > Perhaps we can choose the default depending on whether or not any HID > > devices are attached to given controller? > > Is "resume on keyboard activity" really all that needed? Both my laptops > and my desktop resume fine after pressing the power button. > > Also consider the following cases: > - laptop has been suspended with external USB mouse connected > - mouse is moved (accidentally or because it is in the way of a coffee > cup) > - mouse cable is removed before putting the laptop in a bag for > transport > - laptop is in docking station with USB mouse/kbd connected to that > - again, mouse gets moved for some reason > - laptop is undocked while suspended > - or the reverse: laptop gets docked > > IMO it is not desirable that the system gets resumed as a result of any of > those actions. I'm not complete sure that it would in all those cases, > but have they been considered? > > And in general I've always been in favor of things only happening > automagically if I've explicitly asked for that, and not by default. I don't mind reverting the "automatically enable PCI wakeup" commit. But we should first come to a definite policy for kernel default wakeup settings, rather than deciding things piecemeal for different subsystems. My proposal: Devices and events that are clearly associated with system wakeup should be enabled by default. For example: Power button and laptop lid. All other devices capable of waking up the system should be disabled by default. This presumably includes every PCI device. If users want keyboard or mouse events to cause a system resume then they will have to configure their desktop management program to enable it. Devices not capable of directly waking the system can be enabled. This includes things like USB devices, which have to pass a wakeup request through their parent and therefore can't wake up the system unless the parent is also enabled for wakeup. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/