Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754450AbZAIRmb (ORCPT ); Fri, 9 Jan 2009 12:42:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751845AbZAIRmU (ORCPT ); Fri, 9 Jan 2009 12:42:20 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:59497 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbZAIRmT (ORCPT ); Fri, 9 Jan 2009 12:42:19 -0500 Date: Fri, 9 Jan 2009 09:41:42 -0800 From: Dirk Hohndel To: Andi Kleen Cc: Matthew Wilcox , Andi Kleen , "H. Peter Anvin" , Ingo Molnar , jim owens , Linus Torvalds , Chris Mason , Peter Zijlstra , Steven Rostedt , paulmck@linux.vnet.ibm.com, Gregory Haskins , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich , jh@suse.cz Subject: Re: [patch] measurements, numbers about CONFIG_OPTIMIZE_INLINING=y impact Message-ID: <20090109094142.367012b6@infradead.org> In-Reply-To: <20090109174719.GG26290@one.firstfloor.org> References: <20090108183306.GA22916@elte.hu> <496648C7.5050700@zytor.com> <20090109130057.GA31845@elte.hu> <49675920.4050205@hp.com> <20090109153508.GA4671@elte.hu> <49677CB1.3030701@zytor.com> <20090109084620.3c711aad@infradead.org> <20090109172011.GD26290@one.firstfloor.org> <20090109172801.GC6936@parisc-linux.org> <20090109174719.GG26290@one.firstfloor.org> X-Mailer: Claws Mail 3.6.1 (GTK+ 2.14.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 37 On Fri, 9 Jan 2009 18:47:19 +0100 Andi Kleen wrote: > On Fri, Jan 09, 2009 at 10:28:01AM -0700, Matthew Wilcox wrote: > > On Fri, Jan 09, 2009 at 06:20:11PM +0100, Andi Kleen wrote: > > > Also cc Honza in case he has comments (you might want > > > to review more of the thread in the archives) > > > > I think this particular bug is already known and discussed: > > I thought so initially too, but: > > > > > http://gcc.gnu.org/ml/gcc/2008-12/msg00365.html > > > > and it hints at being fixed with gcc 4.4. Does anyone want to test > > that? > > Hugh already tested with 4.4 and it didn't work well. At least > a lot of the low level asm inlines were not inlined. > So it looks like it's still mistuned for the kernel. I think that's the point. gcc will not get it right. So we need to do it ourselves in the kernel sources. We may not like it, but it's the only way to guarantee reproducable reliable inline / noinline decisions. /D -- Dirk Hohndel Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/