Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755312AbZAITVP (ORCPT ); Fri, 9 Jan 2009 14:21:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753486AbZAITUy (ORCPT ); Fri, 9 Jan 2009 14:20:54 -0500 Received: from one.firstfloor.org ([213.235.205.2]:57560 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbZAITUx (ORCPT ); Fri, 9 Jan 2009 14:20:53 -0500 Date: Fri, 9 Jan 2009 20:35:06 +0100 From: Andi Kleen To: Linus Torvalds Cc: Andi Kleen , Dirk Hohndel , Matthew Wilcox , "H. Peter Anvin" , Ingo Molnar , jim owens , Chris Mason , Peter Zijlstra , Steven Rostedt , paulmck@linux.vnet.ibm.com, Gregory Haskins , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich , jh@suse.cz Subject: Re: [patch] measurements, numbers about CONFIG_OPTIMIZE_INLINING=y impact Message-ID: <20090109193506.GL26290@one.firstfloor.org> References: <49677CB1.3030701@zytor.com> <20090109084620.3c711aad@infradead.org> <20090109172011.GD26290@one.firstfloor.org> <20090109172801.GC6936@parisc-linux.org> <20090109174719.GG26290@one.firstfloor.org> <20090109094142.367012b6@infradead.org> <20090109180213.GH26290@one.firstfloor.org> <20090109185509.GJ26290@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 30 > What happens when you say -fno-inline-functions-called-once? Does it > disable inlining for those functions IN GENERAL, or just for the LARGE It does disable it in general, unless they're marked inline explicitely : The traditional gcc 2.x rules were: I Only inline what is marked inline (but it can decide to not inline) II Also inline others heuristically only with -O3 / -finline-functions [which we don't set in the kernel] Then at some point this additional rule was added: - Also inline everything static that is only called once [on the theory that this shrinks code size which is true according to my measurements] -fno-inline-functions-called once disables this new rule. It's very well and clearly defined. -Andi -- ak@linux.intel.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/