Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759246AbZAIWLS (ORCPT ); Fri, 9 Jan 2009 17:11:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755115AbZAIWKx (ORCPT ); Fri, 9 Jan 2009 17:10:53 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38286 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754212AbZAIWKv (ORCPT ); Fri, 9 Jan 2009 17:10:51 -0500 Date: Fri, 9 Jan 2009 14:09:38 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Harvey Harrison cc: Ingo Molnar , "H. Peter Anvin" , Andi Kleen , Chris Mason , Peter Zijlstra , Steven Rostedt , paulmck@linux.vnet.ibm.com, Gregory Haskins , Matthew Wilcox , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich Subject: Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning In-Reply-To: <1231538387.5825.2.camel@brick> Message-ID: References: <1231434515.14304.27.camel@think.oraclecorp.com> <20090108183306.GA22916@elte.hu> <20090108190038.GH496@one.firstfloor.org> <4966AB74.2090104@zytor.com> <20090109133710.GB31845@elte.hu> <20090109204103.GA17212@elte.hu> <20090109213442.GA20051@elte.hu> <1231537320.5726.2.camel@brick> <1231538387.5825.2.camel@brick> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1288 Lines: 38 On Fri, 9 Jan 2009, Harvey Harrison wrote: > > > > Of course, at that point you might as well argue that the thing should not > > exist at all, and that such a flag should just be removed entirely. Which > > I certainly agree with - I think the only flag we need is "inline", and I > > think it should mean what it damn well says. > > Also agreed, but there needs to start being some education about _not_ using > inline so much in the kernel. Actually, the nice part about "inline_hint" would be that then we could have some nice config option like #ifdef CONFIG_FULL_CALL_TRACE #define inline_hint noinline #elif defined(CONFIG_TRUST_COMPILER) #define inline_hint /* */ #else #define inline_hint __inline #endif and now the _only_ thing we need to do is to remove the #define __inline __force_inline thing, and just agree that "__inline" is the "native compiler meaning". We have a few users of "__inline", but not very many. We can leave them alone, or just convert them to __inline__ or inline. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/