Date: Fri, 9 Jan 2009 14:16:42 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: kobayashi.kk@ncos.nec.co.jp, kosaki.motohiro@jp.fujitsu.com,
       linux-kernel@vger.kernel.org, h-shimamoto@ct.jp.nec.com
Subject: Re: [PATCH 2/3 v2] proc: Export statistics for softirq to /proc
Message-Id: <20090109141642.61540741.akpm@linux-foundation.org>
In-Reply-To: <20081126190603.3CC3.KOSAKI.MOTOHIRO@jp.fujitsu.com>
References: <20081121202232.0489f84b.kobayashi.kk@ncos.nec.co.jp>
	<20081121202708.95ec8b3f.kobayashi.kk@ncos.nec.co.jp>
	<20081126190603.3CC3.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 854
Lines: 28

On Wed, 26 Nov 2008 19:10:28 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> nit
> 
> > @@ -49,6 +50,10 @@ static int show_stat(struct seq_file *p, void *v)
> >  			sum += kstat_irqs_cpu(j, i);
> >  
> >  		sum += arch_irq_stat_cpu(i);
> > +
> > +		for (j = 0; j < NR_SOFTIRQS; j++)
> > +			sum_softirq += kstat_softirqs_cpu(j, i);
> > +
> >  	}
> 
> You can calcurate per_irq_sum here.
> Typically, # of possible cpu are very big.
> 
> So, I don't like unnecessary twrice looping.

I was about to send these patches to Linus, but it seems that this
optmisation hasn't been addressed?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/