Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759295AbZAIWZm (ORCPT ); Fri, 9 Jan 2009 17:25:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756884AbZAIWZX (ORCPT ); Fri, 9 Jan 2009 17:25:23 -0500 Received: from wf-out-1314.google.com ([209.85.200.170]:34678 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757888AbZAIWZV (ORCPT ); Fri, 9 Jan 2009 17:25:21 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=BwGqIY88SNAo1fj7PlxkMkudTm+Br+o74kPaV0fGfMlyec8oADnwAvvxKYMCy1J9oE 0e1dmWwfbuZ/cYF7RzUHr3RC+1h3DsjAU7KkmPpLvYjWp6UL4B4X21XLBQGHu1rJkE5S f7tFEphX+A6B5XS7ngI+4GV6SBe8kOW8Zya4I= Subject: Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning From: Harvey Harrison To: Linus Torvalds Cc: Ingo Molnar , "H. Peter Anvin" , Andi Kleen , Chris Mason , Peter Zijlstra , Steven Rostedt , paulmck@linux.vnet.ibm.com, Gregory Haskins , Matthew Wilcox , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich In-Reply-To: References: <1231434515.14304.27.camel@think.oraclecorp.com> <20090108183306.GA22916@elte.hu> <20090108190038.GH496@one.firstfloor.org> <4966AB74.2090104@zytor.com> <20090109133710.GB31845@elte.hu> <20090109204103.GA17212@elte.hu> <20090109213442.GA20051@elte.hu> <1231537320.5726.2.camel@brick> <1231538387.5825.2.camel@brick> Content-Type: text/plain Date: Fri, 09 Jan 2009 14:25:18 -0800 Message-Id: <1231539918.5825.7.camel@brick> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 48 On Fri, 2009-01-09 at 14:09 -0800, Linus Torvalds wrote: > Actually, the nice part about "inline_hint" would be that then we could > have some nice config option like > > #ifdef CONFIG_FULL_CALL_TRACE > #define inline_hint noinline > #elif defined(CONFIG_TRUST_COMPILER) > #define inline_hint /* */ > #else > #define inline_hint __inline > #endif > > and now the _only_ thing we need to do is to remove the > > #define __inline __force_inline > > thing, and just agree that "__inline" is the "native compiler meaning". > > We have a few users of "__inline", but not very many. We can leave them > alone, or just convert them to __inline__ or inline. > Oh yeah, and figure out what actually breaks on alpha such that they added the following (arch/alpha/include/asm/compiler.h) #ifdef __KERNEL__ /* Some idiots over in thought inline should imply always_inline. This breaks stuff. We'll include this file whenever we run into such problems. */ #include #undef inline #undef __inline__ #undef __inline #undef __always_inline #define __always_inline inline __attribute__((always_inline)) #endif /* __KERNEL__ */ Cheers, Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/