Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932603AbZAIXje (ORCPT ); Fri, 9 Jan 2009 18:39:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760392AbZAIXiy (ORCPT ); Fri, 9 Jan 2009 18:38:54 -0500 Received: from nf-out-0910.google.com ([64.233.182.188]:52863 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755889AbZAIXiw (ORCPT ); Fri, 9 Jan 2009 18:38:52 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; b=dycv5fr5/tHXF8+lzxje7IFUv1meqP9oonaLQdqlE8RkaJO0uG5KF/KdobDpmjWKd9 utO9VAoImIL36xqVL/KsBelEB29266w7NqsELjgWuJsJ4OYEe+bsey/I7EQkizRxJkw0 VoANL8YFIoRyA94iFzp0kp7aF+E+DklYk3/r4= Subject: [PATCH 1/5] Fix dubious bitwise 'or' usage spotted by sparse. To: LKML From: Alexey Zaytsev Cc: Jiri Kosina , Trivial Kernel Patches Date: Sat, 10 Jan 2009 02:47:57 +0300 Message-ID: <20090109234757.11800.1259.stgit@zaytsev.su> In-Reply-To: <20090109234113.11800.55672.stgit@zaytsev.su> References: <20090109234113.11800.55672.stgit@zaytsev.su> User-Agent: StGit/0.14.3.292.gb975 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 27 It doesn't change the semantics, but it looks like the logical 'or' was meant to be used here. Signed-off-by: Alexey Zaytsev --- mm/page_alloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index d8ac014..6923237 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -306,7 +306,7 @@ static void destroy_compound_page(struct page *page, unsigned long order) for (i = 1; i < nr_pages; i++) { struct page *p = page + i; - if (unlikely(!PageTail(p) | + if (unlikely(!PageTail(p) || (p->first_page != page))) bad_page(page); __ClearPageTail(p); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/