Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758510AbZAJA1s (ORCPT ); Fri, 9 Jan 2009 19:27:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760186AbZAJA1Q (ORCPT ); Fri, 9 Jan 2009 19:27:16 -0500 Received: from smtp-out.google.com ([216.239.45.13]:49793 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932645AbZAJA1N (ORCPT ); Fri, 9 Jan 2009 19:27:13 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: content-type:content-transfer-encoding:x-gmailtapped-by:x-gmailtapped; b=Epu5tgvwcruGbHSrGldlPZF9/gBAj3Nni/E55MKrabRzbc8U6PnleyKSpSHMIzgvU BaIXGJhZJ4v4G/f5OB3JQ== MIME-Version: 1.0 In-Reply-To: <604427e00901081840pa6dcc41u9a7a5c69302c7b60@mail.gmail.com> References: <604427e00901051539x52ab85bcua94cd8036e5b619a@mail.gmail.com> <604427e00901081840pa6dcc41u9a7a5c69302c7b60@mail.gmail.com> Date: Fri, 9 Jan 2009 16:27:07 -0800 Message-ID: <604427e00901091627n7c909abt6aa1f01c181ad65d@mail.gmail.com> Subject: Re: [PATCH]Fix: 32bit binary has 64bit address of stack vma From: Ying Han To: linux-mm , linux-kernel , Mike Waychison , Rohit Seth , Andrew Morton , linux-api@vger.kernel.org, Oleg Nesterov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-GMailtapped-By: 172.28.16.147 X-GMailtapped: yinghan Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1970 Lines: 53 friendly ping... On Thu, Jan 8, 2009 at 6:40 PM, Ying Han wrote: > On Mon, Jan 5, 2009 at 3:39 PM, Ying Han wrote: >> From: Ying Han >> >> Fix 32bit binary get 64bit stack vma offset. >> >> 32bit binary running on 64bit system, the /proc/pid/maps shows for the >> vma represents stack get a 64bit adress: >> ff96c000-ff981000 rwxp 7ffffffea000 00:00 0 [stack] >> >> Signed-off-by: Ying Han >> >> fs/exec.c | 5 +- >> >> diff --git a/fs/exec.c b/fs/exec.c >> index 4e834f1..8c3eff4 100644 >> --- a/fs/exec.c >> +++ b/fs/exec.c >> @@ -517,6 +517,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns >> unsigned long length = old_end - old_start; >> unsigned long new_start = old_start - shift; >> unsigned long new_end = old_end - shift; >> + unsigned long new_pgoff = new_start >> PAGE_SHIFT; >> struct mmu_gather *tlb; >> >> BUG_ON(new_start > new_end); >> @@ -531,7 +532,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns >> /* >> * cover the whole range: [new_start, old_end) >> */ >> - vma_adjust(vma, new_start, old_end, vma->vm_pgoff, NULL); >> + vma_adjust(vma, new_start, old_end, new_pgoff, NULL); >> >> /* >> * move the page tables downwards, on failure we rely on >> @@ -564,7 +565,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns >> /* >> * shrink the vma to just the new range. >> */ >> - vma_adjust(vma, new_start, new_end, vma->vm_pgoff, NULL); >> + vma_adjust(vma, new_start, new_end, new_pgoff, NULL); >> >> return 0; >> } >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/