Date: Fri, 9 Jan 2009 16:58:08 -0800 (PST)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Arjan van de Ven <arjan@infradead.org>
cc: linux-ide@vger.kernel.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       jgarzik@pobox.net
Subject: Re: libata: make parallel port scan a per-host opt-in feature
In-Reply-To: <alpine.LFD.2.00.0901091655530.6528@localhost.localdomain>
Message-ID: <alpine.LFD.2.00.0901091657090.6528@localhost.localdomain>
References: <20090109161455.08d5a54c@infradead.org> <alpine.LFD.2.00.0901091655530.6528@localhost.localdomain>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 660
Lines: 24


On Fri, 9 Jan 2009, Linus Torvalds wrote:

> 
> 
> On Fri, 9 Jan 2009, Arjan van de Ven wrote:
> >  
> > +	if (!hpriv->cap & HOST_CAP_SSS)
> > +		host->flags |= ATA_HOST_PARALLEL_SCAN;
> > +
> 
> I don't think that does what you think it does.

And furthermore I'm surprised gcc doesn't warn about it. It would seem to 
be an obvious thing to warn about. I'll see what a sparse warning would 
look like.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/