Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932531AbZAJA6w (ORCPT ); Fri, 9 Jan 2009 19:58:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760482AbZAJA6h (ORCPT ); Fri, 9 Jan 2009 19:58:37 -0500 Received: from casper.infradead.org ([85.118.1.10]:55828 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759433AbZAJA6g (ORCPT ); Fri, 9 Jan 2009 19:58:36 -0500 Date: Fri, 9 Jan 2009 17:00:41 -0800 From: Arjan van de Ven To: Linus Torvalds Cc: linux-ide@vger.kernel.org, Linux Kernel Mailing List , jgarzik@pobox.net Subject: Re: libata: make parallel port scan a per-host opt-in feature Message-ID: <20090109170041.2d830cd5@infradead.org> In-Reply-To: References: <20090109161455.08d5a54c@infradead.org> Organization: Intel X-Mailer: Claws Mail 3.6.1 (GTK+ 2.14.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 26 On Fri, 9 Jan 2009 16:56:59 -0800 (PST) Linus Torvalds wrote: > > > On Fri, 9 Jan 2009, Arjan van de Ven wrote: > > > > + if (!hpriv->cap & HOST_CAP_SSS) > > + host->flags |= ATA_HOST_PARALLEL_SCAN; > > + > > I don't think that does what you think it does. > > Linus argh two few ()'s -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/