Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932593AbZAJBBN (ORCPT ); Fri, 9 Jan 2009 20:01:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754835AbZAJBA5 (ORCPT ); Fri, 9 Jan 2009 20:00:57 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:32969 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754213AbZAJBA4 (ORCPT ); Fri, 9 Jan 2009 20:00:56 -0500 Date: Fri, 9 Jan 2009 17:00:47 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Arjan van de Ven cc: linux-ide@vger.kernel.org, Linux Kernel Mailing List , jgarzik@pobox.net Subject: Re: libata: make parallel port scan a per-host opt-in feature In-Reply-To: Message-ID: References: <20090109161455.08d5a54c@infradead.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 30 On Fri, 9 Jan 2009, Linus Torvalds wrote: > > On Fri, 9 Jan 2009, Linus Torvalds wrote: > > > > On Fri, 9 Jan 2009, Arjan van de Ven wrote: > > > > > > + if (!hpriv->cap & HOST_CAP_SSS) > > > + host->flags |= ATA_HOST_PARALLEL_SCAN; > > > + > > > > I don't think that does what you think it does. > > And furthermore I'm surprised gcc doesn't warn about it. It would seem to > be an obvious thing to warn about. I'll see what a sparse warning would > look like. Heh. sparse already warns: warning: dubious: !x & y although I'm not sure that's necessarily the most readable warning ever. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/