From: Roland Dreier <rdreier@cisco.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Jens Axboe <jens.axboe@oracle.com>, Greg Kroah-Hartman <gregkh@suse.de>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix register_disk() when name has '/' in it
References: <adaljtjog90.fsf@cisco.com>
	<ac3eb2510901092208q1bbaca38xc1aefa9247b86f42@mail.gmail.com>
Date: Fri, 09 Jan 2009 22:11:34 -0800
In-Reply-To: <ac3eb2510901092208q1bbaca38xc1aefa9247b86f42@mail.gmail.com>
	(Kay Sievers's message of "Sat, 10 Jan 2009 07:08:01 +0100")
Message-ID: <adahc47ofl5.fsf@cisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 975
Lines: 21

 > > Commit 3ada8b7e ("block: struct device - replace bus_id with dev_name(),
 > > dev_set_name()") deleted the code in register_disk() that changed a '/'
 > > to a '!' in the device name when registering a disk.
 > 
 > Hmm, this is done in the core, for all devices since a while:
 >   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f255651fb41c111ee35a2ae632df8ce9bd61def
 > 
 > We should find what is going wrong here, instead of putting that code back.

The commit you point to is for kobject_set_name() ... but dev_set_name()
is still just setting dev->bus_id (at least in Linus's current tree).

If you want I can send a patch putting the conversion into
dev_set_name() for now instead.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/