Date: Fri, 09 Jan 2009 22:13:48 -0800 (PST)
Message-Id: <20090109.221348.166902734.davem@davemloft.net>
To: alexey.zaytsev@gmail.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, rostedt@goodmis.org
Subject: Re: [PATCH] Disable branch profiling macros when sparsed.
From: David Miller <davem@davemloft.net>
In-Reply-To: <20090110052727.5471.3654.stgit@zaytsev.su>
References: <20090110052727.5471.3654.stgit@zaytsev.su>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 958
Lines: 23

From: Alexey Zaytsev <alexey.zaytsev@gmail.com>
Date: Sat, 10 Jan 2009 08:57:28 +0300

> The macros produce lots of unneeded warnings when
> recursive if(({ .. if() {..} ..})) {..} and such
> are substituted. And there is no point in sparsing
> them anyway. This is useful if someone decides to
> sparse an allyesconfig kernel.
> 
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>

If even sparse can't handle these things, it's no surprise
how many gcc bogus warning problems we've run into because
of this hairy if() macro.

I don't think it's a good precedence to do this.  It's giving
up on trying to implement the branch tracer in a way that
results in a kernel build that produces useful warnings.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/