Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755828AbZAJPFg (ORCPT ); Sat, 10 Jan 2009 10:05:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752538AbZAJPFY (ORCPT ); Sat, 10 Jan 2009 10:05:24 -0500 Received: from katalix.com ([82.103.140.233]:47888 "EHLO mail.katalix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbZAJPFX (ORCPT ); Sat, 10 Jan 2009 10:05:23 -0500 Message-ID: <4968B929.10801@katalix.com> Date: Sat, 10 Jan 2009 15:05:13 +0000 From: James Chapman Organization: Katalix Systems Ltd User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Cyrill Gorcunov CC: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devel@openvz.org, xemul@openvz.org Subject: Re: [RFC 3/4] net: pppol2tp - introduce net-namespace functionality References: <20090109195154.320495476@gmail.com>> <4967accc.0c58560a.2ee6.3de4@mx.google.com> <49688120.9000507@katalix.com> <20090110111359.GA29349@localhost> <20090110125444.GB29349@localhost> In-Reply-To: <20090110125444.GB29349@localhost> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 35 Cyrill Gorcunov wrote: > [Cyrill Gorcunov - Sat, Jan 10, 2009 at 02:13:59PM +0300] > | [James Chapman - Sat, Jan 10, 2009 at 11:06:08AM +0000] > | | Cyrill Gorcunov wrote: > | | > - Each tunnel and appropriate lock are inside own namespace now. > | | > - pppox code allows to create per-namespace sockets for > | | > both PX_PROTO_OE and PX_PROTO_OL2TP protocols. Actually since > | | > now pppox_create support net-namespaces new PPPo... protocols > | | > (if they ever will be) should support net-namespace too otherwise > | | > explicit check for &init_net would be needed. Ok, I tested this in my L2TP setup. The first ppp session setup fails because the PPPIOCNEWUNIT ioctl returns -EEXIST. I think the problem is the logic in ppp_create_interface(), which does the following to create a new ppp interface: /* Initialize the new ppp unit */ ppp->file.index = unit; sprintf(dev->name, "ppp%d", unit); ret = register_netdev(dev); Looks like there is more work to do in the ppp changes. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/