Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753546AbZAJPUY (ORCPT ); Sat, 10 Jan 2009 10:20:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751913AbZAJPUG (ORCPT ); Sat, 10 Jan 2009 10:20:06 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:60497 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbZAJPUE (ORCPT ); Sat, 10 Jan 2009 10:20:04 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=LTXQbbLw+fPlAMv3/9YrMioVdGMuLcoV38tVdpdmPLAkRIk91X7kWE8xydm6onY6c5 9Sb84gvY50z8or9a/riBY1GoXxJ4KRwH8/4pMYSfgRYEApaYHcaSfmB9nwaIxvijdkMK 4oF6DpHjR2K5jAvHctAH2gZXRoqKuNgJraRDw= Date: Sat, 10 Jan 2009 18:19:58 +0300 From: Cyrill Gorcunov To: James Chapman Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devel@openvz.org, xemul@openvz.org Subject: Re: [RFC 3/4] net: pppol2tp - introduce net-namespace functionality Message-ID: <20090110151958.GC29349@localhost> References: <20090109195154.320495476@gmail.com>> <4967accc.0c58560a.2ee6.3de4@mx.google.com> <49688120.9000507@katalix.com> <20090110111359.GA29349@localhost> <20090110125444.GB29349@localhost> <4968B929.10801@katalix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4968B929.10801@katalix.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1600 Lines: 41 [James Chapman - Sat, Jan 10, 2009 at 03:05:13PM +0000] | Cyrill Gorcunov wrote: | > [Cyrill Gorcunov - Sat, Jan 10, 2009 at 02:13:59PM +0300] | > | [James Chapman - Sat, Jan 10, 2009 at 11:06:08AM +0000] | > | | Cyrill Gorcunov wrote: | > | | > - Each tunnel and appropriate lock are inside own namespace now. | > | | > - pppox code allows to create per-namespace sockets for | > | | > both PX_PROTO_OE and PX_PROTO_OL2TP protocols. Actually since | > | | > now pppox_create support net-namespaces new PPPo... protocols | > | | > (if they ever will be) should support net-namespace too otherwise | > | | > explicit check for &init_net would be needed. | | Ok, I tested this in my L2TP setup. The first ppp session setup fails | because the PPPIOCNEWUNIT ioctl returns -EEXIST. I think the problem is | the logic in ppp_create_interface(), which does the following to create | a new ppp interface: | | /* Initialize the new ppp unit */ | ppp->file.index = unit; | sprintf(dev->name, "ppp%d", unit); | | ret = register_netdev(dev); | | Looks like there is more work to do in the ppp changes. | | -- | James Chapman | Katalix Systems Ltd | http://www.katalix.com | Catalysts for your Embedded Linux software development | Thanks a lot James for testing!!! Will keep you in touch. Thanks again! - Cyrill - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/