Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164AbZAJUug (ORCPT ); Sat, 10 Jan 2009 15:50:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751668AbZAJUu0 (ORCPT ); Sat, 10 Jan 2009 15:50:26 -0500 Received: from h155.mvista.com ([63.81.120.155]:2377 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751131AbZAJUuZ (ORCPT ); Sat, 10 Jan 2009 15:50:25 -0500 Message-ID: <49690A0B.6010701@ru.mvista.com> Date: Sat, 10 Jan 2009 23:50:19 +0300 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Jeff Garzik Cc: Alan Cox , Ingo Molnar , Christian Borntraeger , linux-ide@vger.kernel.org, lkml Subject: Re: [bisected] Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750() References: <200901091334.55823.borntraeger@de.ibm.com> <200901101009.13699.borntraeger@de.ibm.com> <20090110104114.633cacd8@lxorguk.ukuu.org.uk> <200901101242.05203.borntraeger@de.ibm.com> <49688B63.5030105@ru.mvista.com> <20090110122130.318cf168@lxorguk.ukuu.org.uk> <20090110130745.GA14049@elte.hu> <49689EA8.20506@garzik.org> <20090110132412.GB14049@elte.hu> <20090110133617.GA22304@elte.hu> <20090110135731.0da08c90@lxorguk.ukuu.org.uk> <4968BA6F.8050207@ru.mvista.com> <20090110152800.44308491@lxorguk.ukuu.org.uk> <4968C5CA.6010508@ru.mvista.com> <4968FFD7.6070302@ru.mvista.com> <49690589.1070809@garzik.org> In-Reply-To: <49690589.1070809@garzik.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 25 Hello. Jeff Garzik wrote: >> Correctly indeed? I'm not at all sure it's correct to read an extra >> 16-bit word off the device when it thinks it's already done with the >> data transfer. This is not the same as to read 16-bit word and ignore >> its MSB as it happened. The same concern about the writes... Note >> that the IDE code doesn't do this... > > Nod. And that gets us back to the original point... Note that Alan's point is still valid: this WARN_ON_ONCE() would incorrectly trigger on odd length ATAPI transfers. > Jeff MBR Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/