Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044AbZAJVZu (ORCPT ); Sat, 10 Jan 2009 16:25:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753303AbZAJVZ0 (ORCPT ); Sat, 10 Jan 2009 16:25:26 -0500 Received: from casper.infradead.org ([85.118.1.10]:39742 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752743AbZAJVZY convert rfc822-to-8bit (ORCPT ); Sat, 10 Jan 2009 16:25:24 -0500 Date: Sat, 10 Jan 2009 16:27:11 -0500 From: Arjan van de Ven To: Arjan van de Ven Cc: linux-ide@vger.kernel.org, Linus Torvalds , Linux Kernel Mailing List , jgarzik@pobox.com Subject: [PATCH 2/2] libata: only ports >= 0 need to synchronize Message-ID: <20090110162711.6f99e4ca@infradead.org> In-Reply-To: <20090110162629.4c1d4769@infradead.org> References: <20090109161455.08d5a54c@infradead.org> <20090110162629.4c1d4769@infradead.org> Organization: Intel X-Mailer: Claws Mail 3.6.1 (GTK+ 2.14.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1826 Lines: 48 >From 68db7c1eff38c2e121ccc922fd365f4f086369dc Mon Sep 17 00:00:00 2001 From: Arjan van de Ven Date: Sat, 10 Jan 2009 10:18:44 -0800 Subject: [PATCH] libata: only ports >= 0 need to synchronize In a discussio with Jeff Garzik, he mentioned that the serialization for the libata port probes only needs to be within the domain of a host. This means that for the first port of each host (with ID 0), we don't need to wait, so we can relax our serialization a little. Signed-off-by: Arjan van de Ven --- drivers/ata/libata-core.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 31c0f22..71218d7 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5925,10 +5925,12 @@ static void async_port_probe(void *data, async_cookie_t cookie) * If we're not allowed to scan this host in parallel, * we need to wait until all previous scans have completed * before going further. + * Jeff Garzik says this is only within a controller, so we + * don't need to wait for port 0, only for later ports. */ - if (!(ap->host->flags & ATA_HOST_PARALLEL_SCAN)) + if (!(ap->host->flags & ATA_HOST_PARALLEL_SCAN) && ap->port_no != 0) async_synchronize_cookie(cookie); - + /* probe */ if (ap->ops->error_handler) { struct ata_eh_info *ehi = &ap->link.eh_info; -- 1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/