Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755062AbZAJXFq (ORCPT ); Sat, 10 Jan 2009 18:05:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755494AbZAJXFY (ORCPT ); Sat, 10 Jan 2009 18:05:24 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:47320 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755088AbZAJXFW (ORCPT ); Sat, 10 Jan 2009 18:05:22 -0500 Date: Sun, 11 Jan 2009 00:04:54 +0100 From: Ingo Molnar To: Joerg Roedel Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, dwmw2@infradead.org, fujita.tomonori@lab.ntt.co.jp, netdev@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH 15/16] dma-debug: x86 architecture bindings Message-ID: <20090110230454.GI17917@elte.hu> References: <1231517970-20288-1-git-send-email-joerg.roedel@amd.com> <1231517970-20288-16-git-send-email-joerg.roedel@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1231517970-20288-16-git-send-email-joerg.roedel@amd.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 21 * Joerg Roedel wrote: > @@ -105,6 +109,7 @@ dma_unmap_single(struct device *dev, dma_addr_t addr, size_t size, > struct dma_mapping_ops *ops = get_dma_ops(dev); > > BUG_ON(!valid_dma_direction(direction)); > + debug_unmap_single(dev, addr, size, direction); It all looks very nice, i've got one small namespace structure request: could you please name all the callbacks in a consistent way, so that they mirror the method they instrument - with a "debug_" prefix? I.e. the above one would be: debug_dma_unmap_single(). Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/