Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbZAKNLW (ORCPT ); Sun, 11 Jan 2009 08:11:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751698AbZAKNLN (ORCPT ); Sun, 11 Jan 2009 08:11:13 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:38132 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbZAKNLN (ORCPT ); Sun, 11 Jan 2009 08:11:13 -0500 Subject: Re: Build error on latest git From: Jaswinder Singh Rajput To: Jaswinder Singh Rajput Cc: Petr Titera , linux-kernel@vger.kernel.org, Ingo Molnar In-Reply-To: <3f9a31f40901110506v646bd599q863be03accbfd8b2@mail.gmail.com> References: <4969C096.9060909@century.cz> <4969DEA0.5020301@century.cz> <3f9a31f40901110506v646bd599q863be03accbfd8b2@mail.gmail.com> Content-Type: text/plain Date: Sun, 11 Jan 2009 18:38:55 +0530 Message-Id: <1231679335.3244.1.camel@jaswinder.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1645 Lines: 60 On Sun, 2009-01-11 at 18:36 +0530, Jaswinder Singh Rajput wrote: > On Sun, Jan 11, 2009 at 5:27 PM, Petr Titera wrote: > > Going through source it seems to me (still building) that it is caused by > > including asm/smp.h only if build with CONFIG_SMP. This patch seems to fix > > this > > > > diff --git a/include/linux/smp.h b/include/linux/smp.h > > index b824669..fd51bb9 100644 > > --- a/include/linux/smp.h > > +++ b/include/linux/smp.h > > @@ -11,6 +11,8 @@ > > #include > > #include > > > > +#include > > + > > extern void cpu_idle(void); > > > > No, this is wrong. > > asm/smp.h should only be included when CONFIG_SMP is defined. > > I will send fix of this. > Here is the temporary fix, later on I will remove non-smp data from smp.h Subject: [PATCH] x86: mpparse.c fix compilation error Impact: fix compilation error Signed-off-by: Jaswinder Singh Rajput --- arch/x86/kernel/mpparse.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c index 8385d4e..79dae60 100644 --- a/arch/x86/kernel/mpparse.c +++ b/arch/x86/kernel/mpparse.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #ifdef CONFIG_X86_32 -- 1.5.6.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/