Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754248AbZAKNjk (ORCPT ); Sun, 11 Jan 2009 08:39:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752673AbZAKNjb (ORCPT ); Sun, 11 Jan 2009 08:39:31 -0500 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237]:64134 "EHLO tim.rpsys.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbZAKNja (ORCPT ); Sun, 11 Jan 2009 08:39:30 -0500 Subject: Re: [GIT PULL] LED updates for 2.6.29 From: Richard Purdie To: Trent Piepho Cc: Linus Torvalds , Andrew Morton , LKML , Guennadi Liakhovetski , linuxppc-dev@ozlabs.org In-Reply-To: References: <1231500186.5317.9.camel@dax.rpnet.com> <1231543199.5317.63.camel@dax.rpnet.com> <1231633983.5330.32.camel@dax.rpnet.com> <1231674559.5304.13.camel@dax.rpnet.com> Content-Type: text/plain Date: Sun, 11 Jan 2009 13:39:05 +0000 Message-Id: <1231681145.5304.31.camel@dax.rpnet.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1571 Lines: 35 On Sun, 2009-01-11 at 04:58 -0800, Trent Piepho wrote: > It doesn't seem right to merge someone's patches together, make a very > small change, and then no longer credit them as the author. Seems like it > defeats the purpose of the SOB lines for tracing the train of custody too. > If someone looks to see where the code came from, it will look like you > wrote it. Maybe Freescale will say Intel stole our code? Without the SOB, > what record is there in git that Freescale gave permission to put the code > in the kernel? > > I also put some significant effort into writing informative commit > messages, which have been lost. Along with Grant's acks for my patches. It also doesn't make sense to make three changes adding different interfaces and rearranging the same section of code three different times. I'm dropping the patch, please send me a merged version of those patches with a commit message you're happy with. If you want Acked-by lines, we'll have to wait for them on the new patch as I'm going to do this exactly by the book regardless of time pressures now. Please indicate who you want Ack-ed by lines from so I know who to wait for. Also, you'd better exclude the suspend/resume change and credit me for the bitfield change, just to be 100% sure this is all legally accurate. Regards, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/