Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753194AbZAKSIF (ORCPT ); Sun, 11 Jan 2009 13:08:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752826AbZAKSHj (ORCPT ); Sun, 11 Jan 2009 13:07:39 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:37561 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbZAKSHi (ORCPT ); Sun, 11 Jan 2009 13:07:38 -0500 Date: Sun, 11 Jan 2009 19:07:14 +0100 From: Ingo Molnar To: Jeff Chua Cc: Christian Borntraeger , Daniel Drake , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Phil Dibowitz Subject: Re: [Bug #12422] 2.6.28-git can't resume from str Message-ID: <20090111180714.GB15326@elte.hu> References: <20090111162949.GA15338@elte.hu> <200901111736.24350.borntraeger@de.ibm.com> <20090111163904.GA21806@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 31 * Jeff Chua wrote: > On Mon, Jan 12, 2009 at 12:39 AM, Ingo Molnar wrote: > > * Christian Borntraeger wrote > >> I guess Jeff, meant the other way around. > >> Since a0e280e0f33f6c859a235fb69a875ed8f3420388 is a fix for a known S2R > >> problem , the earlier patch (before) does of course not work. > > ah, okay. > > So i suspect that at every bisection point, this should be done: > > git cherry-pick a0e280e0f33f6c859a235fb69a875ed8f3420388 > > I started with the latest git, and did this ... > > git bisect start > git bisect bad > git bisect good a0e280e0f33f6c859a235fb69a875ed8f3420388 > > Everything in-between should have > a0e280e0f33f6c859a235fb69a875ed8f3420388 applied? not necessarily - if an intermediate tree that is checked happened to have been based on some earlier -rc, it might have that bug included. Safest is to always cherry-pick that commit. (if it has no dependencies) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/