Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbZAKVx2 (ORCPT ); Sun, 11 Jan 2009 16:53:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751320AbZAKVxQ (ORCPT ); Sun, 11 Jan 2009 16:53:16 -0500 Received: from pfepa.post.tele.dk ([195.41.46.235]:45922 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbZAKVxP (ORCPT ); Sun, 11 Jan 2009 16:53:15 -0500 Date: Sun, 11 Jan 2009 22:54:54 +0100 From: Sam Ravnborg To: Linus Torvalds Cc: Christian Borntraeger , Johannes Schindelin , git@vger.kernel.org, Linux Kernel Mailing List Subject: Re: current git kernel has strange problems during bisect Message-ID: <20090111215454.GA6019@uranus.ravnborg.org> References: <200901111602.53082.borntraeger@de.ibm.com> <200901111607.59054.borntraeger@de.ibm.com> <200901111620.03345.borntraeger@de.ibm.com> <20090111194258.GA4840@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 42 On Sun, Jan 11, 2009 at 12:04:12PM -0800, Linus Torvalds wrote: > > > On Sun, 11 Jan 2009, Sam Ravnborg wrote: > > > > The cost of moving this piece of history from one git tree to another > > git tree is that we make it harder to debug the kernel for the advanced user > > that knows how to do bisect. > > > > It is not like this history would be lost - one just had to look > > somewhere else to find it. > > > > That may be a bad pain/benefit ratio - time will tell. > > Umm. No. > > Time is exactly what makes it useful. It will make all the downsides > shrink, and the advantages stay. > > > There should be a way to avoid such pain when bisecting without > > having to mark a semi-random (for the average person) commit as good. > > Well, you don't actually have to mark that semi-random one as good either. > What you can do is to just mark anything that _only_ contains fs/btrfs as > good. IOW, you don't have to know the magic number - you just have to be > told that "oh, if you only have btrfs files, and you're not actively > bisecting a btrfs bug, just do 'git bisect good' and continue". And we lost 24 hours due to timezone differences etc. and maybe a few testers. Thats my point. There are other obvious ways to do this where we keep history in kernel but do not impact bisect. And we have one frustrated tester already - so this is not a made up example. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/