Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753979AbZALAEl (ORCPT ); Sun, 11 Jan 2009 19:04:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752120AbZALAEb (ORCPT ); Sun, 11 Jan 2009 19:04:31 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:38885 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbZALAEa (ORCPT ); Sun, 11 Jan 2009 19:04:30 -0500 From: "Rafael J. Wysocki" To: Christian Borntraeger Subject: Re: Regression 2.6.28-git: suspend/resume failure. git bisected to usb suspend/resume patch Date: Mon, 12 Jan 2009 01:03:52 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.28-rjw; KDE/4.1.3; x86_64; ; ) Cc: Alan Stern , lkml , "Greg Kroah-Hartman" , linux-usb@vger.kernel.org References: <200901111348.46216.borntraeger@de.ibm.com> In-Reply-To: <200901111348.46216.borntraeger@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901120103.53390.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 41 On Sunday 11 January 2009, Christian Borntraeger wrote: > Hello Alan, > > git bisect found this patch > > a0d4922da2e4ccb0973095d8d29f36f6b1b5f703 is first bad commit > commit a0d4922da2e4ccb0973095d8d29f36f6b1b5f703 > Author: Alan Stern > Date: Wed Dec 17 15:06:03 2008 -0500 > > USB: fix up suspend and resume for PCI host controllers > > This patch (as1192) rearranges the USB PCI host controller suspend and > resume and resume routines: > > > To cause my suspend to ram problem with my Thinkpad T61p. > I can confirm that > a81a81a25d3ecdab777abca87c5ddf484056103d works > and a0d4922da2e4ccb0973095d8d29f36f6b1b5f703 does not work. > > Thing is, 29-rc1 with a0d4922da2e4ccb0973095d8d29f36f6b1b5f703 reverted also > fails with suspend/resume. Seems that there was another problem introduced > after that patch. Please try if suspend-resume works for you if you make commit fa58d305d9925b01830e535896a7227a868a9e15 (PCI PM: Add suspend counterpart of pci_reenable_device) the head of your tree ('git checkout -b test-branch fa58d305d9925b01830e535896a7227a868a9e15'). If it does, please check the same for commit 571ff7584bb9e05fca0eb79752ae55a46faf3a98 (PCI PM: Power-manage devices without drivers during suspend-resume). Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/