Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919AbZALIxY (ORCPT ); Mon, 12 Jan 2009 03:53:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751459AbZALIxO (ORCPT ); Mon, 12 Jan 2009 03:53:14 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:60256 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbZALIxO (ORCPT ); Mon, 12 Jan 2009 03:53:14 -0500 Date: Mon, 12 Jan 2009 09:53:02 +0100 From: Ingo Molnar To: Mike Travis Cc: Christophe Saout , LKML Subject: Re: [PATCH]: xen: fix too early kmalloc call Message-ID: <20090112085302.GB21976@elte.hu> References: <496A4C8F.8070005@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <496A4C8F.8070005@sgi.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2482 Lines: 81 * Mike Travis wrote: > Subject: xen: fix too early kmalloc call > > From: Christophe Saout > > Impact: fixes bootup of xen. > > Christophe reported the following problem: > > > (basically it seems that SLAB is not yet up, with earlyprintk it is > > giving me an Oops in __kmalloc before) > > Replace call to kmalloc with alloc_bootmem. > > Also from Christophe: > > (me) > > > Or I could copy the text and submit it as a new patch? > > > > Yes, I would prefer that. Also, my commit message was not really > > following Kernel standards and it's only a very simple change. > > Signed-off-by: Mike Travis i've applied the fix to tip/cpus4096, in the form below. Please submit clean log messages. Your commit description was confused - the patch is From: Christophe, but the message talks about Christophe in the third person. Also, it included conversational bits that have no value for the Git history. Ingo --------------------> >From 28e08861b9afab4168b758fb7b95aa7a4da0f668 Mon Sep 17 00:00:00 2001 From: Christophe Saout Date: Sun, 11 Jan 2009 11:46:23 -0800 Subject: [PATCH] xen: fix too early kmalloc call Impact: fix bootup crash on xen guests SLAB is not yet up, with earlyprintk it is giving me an Oops in __kmalloc. Replace call to kmalloc() with alloc_bootmem(). Reported-by: Christophe Saout Signed-off-by: Mike Travis Signed-off-by: Ingo Molnar --- drivers/xen/events.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index ed7527b..3141e14 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include @@ -831,8 +832,8 @@ void __init xen_init_IRQ(void) int i; size_t size = nr_cpu_ids * sizeof(struct cpu_evtchn_s); - cpu_evtchn_mask_p = kmalloc(size, GFP_KERNEL); - BUG_ON(cpu_evtchn_mask == NULL); + cpu_evtchn_mask_p = alloc_bootmem(size); + BUG_ON(cpu_evtchn_mask_p == NULL); init_evtchn_cpu_bindings(); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/